Re: Move block_range_read_stream_cb batchmode comment

From: Andres Freund <andres(at)anarazel(dot)de>
To: Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Move block_range_read_stream_cb batchmode comment
Date: 2025-08-30 18:14:40
Message-ID: chtu5m6rbjl4h73l2zyhr2o7ex5jg5ymy3srx7bnmmhpubc6bz@u4nfqvole4px
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
> Currently, each usage of block_range_read_stream_cb is accompanied by
> the same comment about the safety of using batchmode (there are 7
> identical comments)

-1 - I think it's better to have the analysis at the point of using the flag
and callback, as otherwise it's too easy to change the callsites to a
different callback, without removing the flag.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-08-30 18:17:15 Re: PG 18 relnotes and RC1
Previous Message Jim Jones 2025-08-30 18:14:29 Re: COPY TO: provide hint when WHERE clause is used