From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
Subject: | Re: PG 18 relnotes and RC1 |
Date: | 2025-08-30 16:52:45 |
Message-ID: | 16021.1756572765@sss.pgh.pa.us |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Second, the release note item added by this commit:
> commit d1073c3b4cc
> Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
> Date: Fri Aug 29 10:18:10 2025 +0200
> Unfortunately src/tools/add_commit_links.pl can't process the <ulink>
> and throws an error because the previous line does not end with a
> parenthesis. If I add "()" after the last line in the text block, it
> works fine, but obviously this is not acceptable.
I suppose that the expectation is that every release note item
will be credited to someone. Why does this item lack a credit?
If we're okay with items not having credits, then
add_commit_links.pl's logic for where to put the <ulink>s needs
improvement. I don't really understand why it's looking for
parens in the first place -- why isn't the rule simply "put them
before the first </para> in the item"?
In either case, I don't agree with hacky workarounds like manually
munged ulink entries ...
> I can commit this once our RC1 git tree freeze is over. Is that Tuesday?
The release freeze doesn't apply to the release notes ;-)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Arseniy Mukhin | 2025-08-30 17:33:09 | Move block_range_read_stream_cb batchmode comment |
Previous Message | Tom Lane | 2025-08-30 16:38:55 | Re: [PATCH] Add error_on_null() to produce an error if the input is null |