Re: Move block_range_read_stream_cb batchmode comment

From: Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Move block_range_read_stream_cb batchmode comment
Date: 2025-08-30 18:41:37
Message-ID: CAE7r3MJgWAeQwSD2VUMM+0qjBgtAA2M=m+sMN=bEffecEXctXg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 30, 2025 at 9:14 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2025-08-30 20:33:09 +0300, Arseniy Mukhin wrote:
> > Currently, each usage of block_range_read_stream_cb is accompanied by
> > the same comment about the safety of using batchmode (there are 7
> > identical comments)
>
> -1 - I think it's better to have the analysis at the point of using the flag
> and callback, as otherwise it's too easy to change the callsites to a
> different callback, without removing the flag.
>

Got the idea, thank you for the explanation.

Best regards,
Arseniy Mukhin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-08-30 18:51:23 Re: PG 18 relnotes and RC1
Previous Message Tom Lane 2025-08-30 18:17:15 Re: PG 18 relnotes and RC1