Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup
Date: 2018-12-29 15:29:28
Message-ID: 23989242-4b75-5666-4b14-d7bd19ff3115@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 22/12/2018 00:42, Michael Paquier wrote:
> What about the following then? This is your second proposal except
> that the sentence refers to the backup current running using "this",
> which shows better the context in my opinion:
> "This backup can be canceled safely, but it will not be usable without
> all the WAL segments.

To much emphasis on the "this" I think, implying that there are other
backups that cannot be canceled safely.

How about "You can safely cancel this backup, ...".

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-12-29 15:31:11 Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup
Previous Message Peter Eisentraut 2018-12-29 15:12:39 Use atexit() in initdb and pg_basebackup