|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>|
|Cc:||Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Sat, Dec 29, 2018 at 04:29:28PM +0100, Peter Eisentraut wrote:
> On 22/12/2018 00:42, Michael Paquier wrote:
>> What about the following then? This is your second proposal except
>> that the sentence refers to the backup current running using "this",
>> which shows better the context in my opinion:
>> "This backup can be canceled safely, but it will not be usable without
>> all the WAL segments.
> To much emphasis on the "this" I think, implying that there are other
> backups that cannot be canceled safely.
> How about "You can safely cancel this backup, ...".
I can live with that, please find an updated patch.
A personal note on the matter: I tend to prefer using the passive form
in such log messages because they are impersonal, and not use the
direct form because it becomes more personally addressed to the user.
I may be living abroad for too long though ;)
|Next Message||Michael Paquier||2018-12-30 05:51:37||Re: plpgsql plugin - stmt_beg/end is not called for top level block of statements|
|Previous Message||Michael Paquier||2018-12-30 05:45:28||Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup|