Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

On Fri, Dec 21, 2018 at 10:43:57AM -0300, Alvaro Herrera wrote:
> errhint("Check that your archive_command is executing properly. "
> + "Backup can be canceled safely, "
> "but the database backup will not be usable without all the WAL segments.")))
>
> I think repeating the same term in the third line is not great. Some
> ideas:
>
> Backups can be canceled safely, but they will not be usable without all the WAL segments.
> The backup can be canceled safely, but it will not be usable without all the WAL segments.
> Database backups can be canceled safely, but the current backup will not be usable without all the WAL segments.
> Database backups can be canceled safely, but no backup will be usable without all the WAL segments.

Yes, I agree that repeating two times the work backup is not great.
What about the following then? This is your second proposal except
that the sentence refers to the backup current running using "this",
which shows better the context in my opinion:
"This backup can be canceled safely, but it will not be usable without
all the WAL segments.
--
Michael