Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup
Date: 2018-12-29 15:31:11
Message-ID: 8f34fead-b245-3f9a-baeb-97100ef1e0f8@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21/12/2018 05:05, Michael Paquier wrote:
> - (errmsg("pg_stop_backup cleanup done, waiting for required WAL segments to be archived")));
> + (errmsg("waiting for required WAL segments to be archived")));

I think this loses the context that this is happening during a base
backup. I'd keep something like "base backup done, waiting ...".

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-12-29 15:36:02 Re: Garbage contents after running autoconf 2.69
Previous Message Peter Eisentraut 2018-12-29 15:29:28 Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup