Re: 'converts internal representation to "..."' comment is confusing

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Steve Chavez <steve(at)supabase(dot)io>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 'converts internal representation to "..."' comment is confusing
Date: 2023-05-15 01:36:53
Message-ID: 2036816.1684114613@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Steve Chavez <steve(at)supabase(dot)io> writes:
> I found "..." confusing in some comments, so this patch changes it to
> "cstring". Which seems to be the intention after all.

Those comments are Berkeley-era, making them probably a decade older
than the "cstring" pseudotype (invented in b663f3443). Perhaps what
you suggest is an improvement, but I'm not sure that appealing to
original intent can make the case.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-05-15 02:08:32 Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Previous Message Tom Lane 2023-05-15 01:25:53 Re: Using make_ctags leaves tags files in git