Re: 'converts internal representation to "..."' comment is confusing

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 'converts internal representation to "..."' comment is confusing
Date: 2023-05-16 12:49:36
Message-ID: CA+TgmobRyH03_gbSVuggQ2Yh5iemhLOawyiNssLOKu-tUmkD1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, May 14, 2023 at 9:37 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Steve Chavez <steve(at)supabase(dot)io> writes:
> > I found "..." confusing in some comments, so this patch changes it to
> > "cstring". Which seems to be the intention after all.
>
> Those comments are Berkeley-era, making them probably a decade older
> than the "cstring" pseudotype (invented in b663f3443). Perhaps what
> you suggest is an improvement, but I'm not sure that appealing to
> original intent can make the case.

FWIW, it does seem like an improvement to me.

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2023-05-16 12:54:43 Re: pgbench: option delaying queries till connections establishment?
Previous Message Robert Haas 2023-05-16 12:27:33 Re: cutting down the TODO list thread