Re: 'converts internal representation to "..."' comment is confusing

From: Steve Chavez <steve(at)supabase(dot)io>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 'converts internal representation to "..."' comment is confusing
Date: 2023-05-15 02:50:45
Message-ID: CAGRrpzbMkhoKJ_4ZWhAL99grMn_WmQKw1qXU9mvUJO6ifveisA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks a lot for the clarification!

The "..." looks enigmatic right now. I think cstring would save newcomers
some head-scratching.

Open to suggestions though.

Best regards,
Steve

On Sun, 14 May 2023 at 22:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Steve Chavez <steve(at)supabase(dot)io> writes:
> > I found "..." confusing in some comments, so this patch changes it to
> > "cstring". Which seems to be the intention after all.
>
> Those comments are Berkeley-era, making them probably a decade older
> than the "cstring" pseudotype (invented in b663f3443). Perhaps what
> you suggest is an improvement, but I'm not sure that appealing to
> original intent can make the case.
>
> regards, tom lane
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-05-15 02:57:31 Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~
Previous Message Zhijie Hou (Fujitsu) 2023-05-15 02:19:53 RE: walsender performance regression due to logical decoding on standby changes