| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remove more archiving overhead |
| Date: | 2022-07-07 22:07:16 |
| Message-ID: | 20220707220716.GA2258527@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 07, 2022 at 05:06:13PM -0400, David Steele wrote:
> On 7/7/22 14:22, Nathan Bossart wrote:
>> On Thu, Jul 07, 2022 at 10:51:42AM -0700, Nathan Bossart wrote:
>> > + library to ensure that it indeed does not overwrite an existing file. When
>> > + a pre-existing file is encountered, the archive library may return
>> > + <literal>true</literal> if the WAL file has identical contents to the
>> > + pre-existing archive. Alternatively, the archive library can return
>>
>> This should likely say something about ensuring the pre-existing file is
>> persisted to disk before returning true.
>
> Agreed.
>
> Also, I'd prefer to remove "indeed" from this sentence (yes, I see that was
> in the original text):
>
> + library to ensure that it indeed does not overwrite an existing
Here's an updated patch.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-add-note-about-re-archiving-in-docs.patch | text/x-diff | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-07 22:07:36 | Re: Postgres picks suboptimal index after building of an extended statistics |
| Previous Message | Christoph Moench-Tegeder | 2022-07-07 22:06:11 | Re: index for inet column |