| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: remove more archiving overhead |
| Date: | 2022-07-07 21:06:13 |
| Message-ID: | ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 7/7/22 14:22, Nathan Bossart wrote:
> On Thu, Jul 07, 2022 at 10:51:42AM -0700, Nathan Bossart wrote:
>> + library to ensure that it indeed does not overwrite an existing file. When
>> + a pre-existing file is encountered, the archive library may return
>> + <literal>true</literal> if the WAL file has identical contents to the
>> + pre-existing archive. Alternatively, the archive library can return
>
> This should likely say something about ensuring the pre-existing file is
> persisted to disk before returning true.
Agreed.
Also, I'd prefer to remove "indeed" from this sentence (yes, I see that
was in the original text):
+ library to ensure that it indeed does not overwrite an existing
Regards,
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-07 21:33:25 | Re: Select Reference Page - Make Join Syntax More Prominent |
| Previous Message | Peter Geoghegan | 2022-07-07 20:45:19 | Re: explain analyze rows=%.0f |