Re: Apple's ranlib warns about protocol_openssl.c

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Apple's ranlib warns about protocol_openssl.c
Date: 2021-12-31 00:49:35
Message-ID: 20211231004935.palztchhpygcs7fj@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2021-12-17 14:26:53 +1300, Thomas Munro wrote:
> On Fri, Dec 17, 2021 at 9:38 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Could be. I tried it on Monterey, but not anything older.
> > (longfin is still on Big Sur, because I've been lazy about
> > updating it.)
>
> Hmm. Happened[1] with Andres's CI scripts, which (at least on the
> version I used here, may not be his latest) runs on macOS Monterey and
> installs openssl from brew which is apparently 3.0.0. Wild guess:
> some versions of openssl define functions, and some define macros, and
> here we're looking for the macros?

I also see it on an m1 mini I got when building against openssl 3.

There is -no_warning_for_no_symbols in apple's ranlib. But perhaps
there's another way around this:
We have ssl_protocol_version_to_openssl() in both be-secure-openssl.c
and fe-secure-openssl.c. Perhaps we should just move it to
protocol_openssl.c?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-12-31 01:03:54 Re: Apple's ranlib warns about protocol_openssl.c
Previous Message Alvaro Herrera 2021-12-30 23:32:29 Re: Column Filtering in Logical Replication