Re: Column Filtering in Logical Replication

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Column Filtering in Logical Replication
Date: 2021-12-30 23:32:29
Message-ID: 202112302332.3dficrkfzcyt@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2021-Dec-30, Justin Pryzby wrote:

Thank you! I've incorporated your proposed fixes.

> > + /*
> > + * Even if the user listed all columns in the column list, we cannot
> > + * allow a column list to be specified when REPLICA IDENTITY is FULL;
> > + * that would cause problems if a new column is added later, because
> > + * that could would have to be included (because of being part of the
> could would is wrong

Hah, yeah, this was "that column would".

> > + * Gets a list of OIDs of all column-partial publications of the given
> > + * relation, that is, those that specify a column list.
> I would call this a "partial-column" publication.

OK, done that way.

Álvaro Herrera Valdivia, Chile —

Attachment Content-Type Size
v14-0001-Avoid-use-of-DEFELEM-enum-in-AlterPublicationStm.patch text/x-diff 5.2 KB
v14-0002-Support-column-lists-for-logical-replication-of-.patch text/x-diff 73.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-12-31 00:49:35 Re: Apple's ranlib warns about protocol_openssl.c
Previous Message Tom Lane 2021-12-30 22:28:38 More pg_dump performance hacking