Re: Pluggable Storage - Andres's take

From: Andres Freund <andres(at)anarazel(dot)de>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Asim R P <apraveen(at)pivotal(dot)io>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, aagrawal(at)pivotal(dot)io, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Subject: Re: Pluggable Storage - Andres's take
Date: 2019-03-09 03:13:10
Message-ID: 20190309031310.6qjht3gzdrj4iytj@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi,

On 2019-03-05 23:07:21 -0800, Andres Freund wrote:
> My next steps are:
> - final polish & push the basic DDL and pg_dump patches
> - cleanup & polish the ON CONFLICT refactoring

Those are pushed.

> - cleanup & polish the patch adding the tableam based scan
> interface. That's by far the largest patch in the series. I might try
> to split it up further, but it's probably not worth it.

I decided not to split it up further, and even merged two small commits
into it. Subdividing it cleanly would have required making some changes
just to undo them in a subsequent patch.

> - improve documentation for the individual callbacks (integrating
> work done by others on this thread), in the header

I've done that for the callbacks in the above commit.

Changes:
- I've added comments to all the callbacks in the first commit / the
scan commit
- I've renamed table_gimmegimmeslot to table_slot_create
- I've made the callbacks and their wrappers more consistently named
- I've added asserts for necessary callbacks in scan commit
- Lots of smaller cleanup
- Added a commit message

While 0001 is pretty bulky, the interesting bits concentrate on a
comparatively small area. I'd appreciate if somebody could give the
comments added in tableam.h a read (both on callbacks, and their
wrappers, as they have different audiences). It'd make sense to first
read the commit message, to understand the goal (and I'd obviously also
appreciate suggestions for improvements there as well).

I'm pretty happy with the current state of the scan patch. I plan to do
two more passes through it (formatting, comment polishing, etc. I don't
know of any functional changes needed), and then commit it, lest
somebody objects.

Greetings,

Andres Freund

Attachment Content-Type Size
v18-0001-tableam-Add-and-use-scan-APIs.patch text/x-diff 238.8 KB
v18-0002-tableam-Only-allow-heap-in-a-number-of-contrib-m.patch text/x-diff 3.1 KB
v18-0003-tableam-Add-insert-delete-update-lock_tuple.patch text/x-diff 90.7 KB
v18-0004-tableam-Add-fetch_row_version.patch text/x-diff 12.2 KB
v18-0005-tableam-Add-use-tableam_fetch_follow_check.patch text/x-diff 3.8 KB
v18-0006-tableam-Add-table_get_latest_tid.patch text/x-diff 4.6 KB
v18-0007-tableam-multi_insert-and-slotify-COPY.patch text/x-diff 23.3 KB
v18-0008-tableam-finish_bulk_insert.patch text/x-diff 5.4 KB
v18-0009-tableam-slotify-CREATE-TABLE-AS-and-CREATE-MATER.patch text/x-diff 4.7 KB
v18-0010-tableam-index-builds.patch text/x-diff 71.2 KB
v18-0011-tableam-relation-creation-VACUUM-FULL-CLUSTER-SE.patch text/x-diff 60.8 KB
v18-0012-tableam-VACUUM-and-ANALYZE.patch text/x-diff 18.4 KB
v18-0013-tableam-planner-size-estimation.patch text/x-diff 11.8 KB
v18-0014-tableam-Sample-Scan-Support.patch text/x-diff 29.0 KB
v18-0015-tableam-bitmap-heap-scan.patch text/x-diff 17.4 KB
v18-0016-WIP-Move-xid-horizon-computation-for-page-level-.patch text/x-diff 23.7 KB
v18-0017-tableam-Add-function-to-determine-newest-xid-amo.patch text/x-diff 3.0 KB
v18-0018-tableam-Fetch-tuples-for-triggers-EPQ-using-a-pr.patch text/x-diff 8.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-03-09 03:18:25 Re: Pluggable Storage - Andres's take
Previous Message Tom Lane 2019-03-09 03:11:26 Re: Should we increase the default vacuum_cost_limit?