Re: Pluggable Storage - Andres's take

Hi,

On 2019-03-05 23:07:21 -0800, Andres Freund wrote:
> My next steps are:
> - final polish & push the basic DDL and pg_dump patches
> - cleanup & polish the ON CONFLICT refactoring

Those are pushed.

> - cleanup & polish the patch adding the tableam based scan
> interface. That's by far the largest patch in the series. I might try
> to split it up further, but it's probably not worth it.

I decided not to split it up further, and even merged two small commits
into it. Subdividing it cleanly would have required making some changes
just to undo them in a subsequent patch.

> - improve documentation for the individual callbacks (integrating
> work done by others on this thread), in the header

I've done that for the callbacks in the above commit.

Changes:
- I've added comments to all the callbacks in the first commit / the
scan commit
- I've renamed table_gimmegimmeslot to table_slot_create
- I've made the callbacks and their wrappers more consistently named
- I've added asserts for necessary callbacks in scan commit
- Lots of smaller cleanup
- Added a commit message

While 0001 is pretty bulky, the interesting bits concentrate on a
comparatively small area. I'd appreciate if somebody could give the
comments added in tableam.h a read (both on callbacks, and their
wrappers, as they have different audiences). It'd make sense to first
read the commit message, to understand the goal (and I'd obviously also
appreciate suggestions for improvements there as well).

I'm pretty happy with the current state of the scan patch. I plan to do
two more passes through it (formatting, comment polishing, etc. I don't
know of any functional changes needed), and then commit it, lest
somebody objects.

Greetings,

Andres Freund