| From: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Asim R P <apraveen(at)pivotal(dot)io>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Ashwin Agrawal <aagrawal(at)pivotal(dot)io>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
| Subject: | Re: Pluggable Storage - Andres's take |
| Date: | 2019-03-16 06:43:10 |
| Message-ID: | CAJrrPGeEL8_uxMBcXa0+p+bmE33uM0Z2M_rxV8QO-hQPoEgp2w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 9, 2019 at 2:13 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> While 0001 is pretty bulky, the interesting bits concentrate on a
> comparatively small area. I'd appreciate if somebody could give the
> comments added in tableam.h a read (both on callbacks, and their
> wrappers, as they have different audiences). It'd make sense to first
> read the commit message, to understand the goal (and I'd obviously also
> appreciate suggestions for improvements there as well).
>
> I'm pretty happy with the current state of the scan patch. I plan to do
> two more passes through it (formatting, comment polishing, etc. I don't
> know of any functional changes needed), and then commit it, lest
> somebody objects.
>
I found couple of typos in the committed patch, attached patch fixes them.
I am not sure about one typo, please check it once.
And I reviewed the 0002 patch, which is a pretty simple and it can be
committed.
Regards,
Haribabu Kommi
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-table-access-methods-typos-correction.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-03-16 08:18:34 | Re: Make pg_checksums complain if compiled BLCKSZ and data folder's block size differ |
| Previous Message | Peter Geoghegan | 2019-03-16 04:16:23 | Re: Making all nbtree entries unique by having heap TIDs participate in comparisons |