Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup
Date: 2018-12-30 05:45:28
Message-ID: 20181230054528.GB608@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 29, 2018 at 04:31:11PM +0100, Peter Eisentraut wrote:
> On 21/12/2018 05:05, Michael Paquier wrote:
>> - (errmsg("pg_stop_backup cleanup done, waiting for required WAL segments to be archived")));
>> + (errmsg("waiting for required WAL segments to be archived")));
>
> I think this loses the context that this is happening during a base
> backup. I'd keep something like "base backup done, waiting ...".

Okay, point taken. I'll send a patch after answering to your other
comments.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-12-30 05:50:46 Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup
Previous Message Michael Paquier 2018-12-30 05:40:57 Re: plpgsql plugin - stmt_beg/end is not called for top level block of statements