Re: plpgsql plugin - stmt_beg/end is not called for top level block of statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plpgsql plugin - stmt_beg/end is not called for top level block of statements
Date: 2018-12-30 05:40:57
Message-ID: 20181230054057.GA608@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 28, 2018 at 04:50:11PM +0900, Michael Paquier wrote:
> Okay, that makes sense, now I got your point. Perhaps somebody else
> has an opinion to offer or has an objection with the proposed change?

And committed this one, after playing more with the instrumentation
callbacks and checking that the change was consistent for functions,
triggers and event triggers.

Attached is the set of tests I used which has some regression tests.
The results won't fail with HEAD at 4203842a, and will generate some
diffs after e0ef136d as Pavel's patch has changed the generated
output.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-12-30 05:45:28 Re: Clean up some elog messages and comments for do_pg_stop_backup and do_pg_start_backup
Previous Message Chapman Flack 2018-12-30 03:58:06 Re: Re: tracking owner of extension-managed objects