| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jakob Egger <jakob(at)eggerapps(dot)at>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG_DIAG_SEVERITY and a possible bug in pq_parse_errornotice() |
| Date: | 2016-08-26 17:05:45 |
| Message-ID: | 20160826170545.GA316209@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> So far as I can find, the attached is all we need to do to introduce a
> new message field. (This patch doesn't address the memory-context
> questions, but it does fix the localization-driven failure demonstrated
> upthread.)
>
> Any objections? Anyone want to bikeshed the field name? I considered
> PG_DIAG_SEVERITY_NONLOCALIZED and PG_DIAG_SEVERITY_ENGLISH before settling
> on PG_DIAG_SEVERITY_ASCII, but I can't say I'm in love with that.
I didn't review the patch, but +1 on the idea. As for the name, I think
ASCII is the wrong thing (as many labels in other languages can be in
ascii too). I vote for NONLOCALIZED.
I see character "s" is already taken in the protocol; that would be my
first preference rather than A. How about Z?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-08-26 17:10:38 | Re: OpenSSL 1.1 breaks configure and more |
| Previous Message | Heikki Linnakangas | 2016-08-26 17:04:07 | Re: OpenSSL 1.1 breaks configure and more |