Re: PG_DIAG_SEVERITY and a possible bug in pq_parse_errornotice()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Jakob Egger <jakob(at)eggerapps(dot)at>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PG_DIAG_SEVERITY and a possible bug in pq_parse_errornotice()
Date: 2016-08-26 17:15:50
Message-ID: 30235.1472231750@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> Any objections? Anyone want to bikeshed the field name? I considered
>> PG_DIAG_SEVERITY_NONLOCALIZED and PG_DIAG_SEVERITY_ENGLISH before settling
>> on PG_DIAG_SEVERITY_ASCII, but I can't say I'm in love with that.

> I didn't review the patch, but +1 on the idea. As for the name, I think
> ASCII is the wrong thing (as many labels in other languages can be in
> ascii too). I vote for NONLOCALIZED.

> I see character "s" is already taken in the protocol; that would be my
> first preference rather than A. How about Z?

One of the reasons I didn't pick NONLOCALIZED was that I couldn't come
up with an appropriate letter for the protocol. I guess Z is okay,
but it's a bit of a stretch (especially if you're of the persuasion
that wants to spell it "nonlocalised"). Maybe V for "seVerity"?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Brandur 2016-08-26 17:44:22 [PATCH] SortSupport for macaddr type
Previous Message Tom Lane 2016-08-26 17:10:38 Re: OpenSSL 1.1 breaks configure and more