| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jakob Egger <jakob(at)eggerapps(dot)at>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PG_DIAG_SEVERITY and a possible bug in pq_parse_errornotice() |
| Date: | 2016-08-26 15:56:56 |
| Message-ID: | 27231.1472227016@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> After sleeping on it, I think the right answer is to introduce the new
> error-message field (and not worry about 9.5). Will work on a patch
> for that, unless I hear objections pretty soon.
So far as I can find, the attached is all we need to do to introduce a
new message field. (This patch doesn't address the memory-context
questions, but it does fix the localization-driven failure demonstrated
upthread.)
Any objections? Anyone want to bikeshed the field name? I considered
PG_DIAG_SEVERITY_NONLOCALIZED and PG_DIAG_SEVERITY_ENGLISH before settling
on PG_DIAG_SEVERITY_ASCII, but I can't say I'm in love with that.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| add-nonlocalized-error-severity.patch | text/x-diff | 9.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2016-08-26 15:58:45 | Re: Renaming of pg_xlog and pg_clog |
| Previous Message | Simon Riggs | 2016-08-26 15:56:19 | Re: WAL consistency check facility |