Re: Online enabling of checksums

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: Michael Banck <michael(dot)banck(at)credativ(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Online enabling of checksums
Date: 2018-03-18 23:01:13
Message-ID: 1C968948-D387-46A7-968C-C6E7BC8315F0@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 18 Mar 2018, at 17:21, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
>> 18 марта 2018 г., в 19:02, Michael Banck <michael(dot)banck(at)credativ(dot)de> написал(а):
>>
>> Otherwise, I had a quick look over v4 and found no further issues.
>> Hopefully I will be able to test it on some bigger test databases next
>> week.
>>
>> I'm switching the state back to 'Waiting on Author'; if you think the
>> above points are moot, maybe switch it back to 'Needs Review' as Andrey
>> Borodin also marked himself down as reviewer and might want to have
>> another look as well.
>
> Yep, i'm already doing another pass on the code again. Hope to finish tomorrow.
> My 2 cents, there's typo in the word "connections"
> + <literal>template0</literal> is by default not accepting connetions, to

Fixed in patch just posted in 84693D0C-772F-45C2-88A1-85B4983A5780(at)yesql(dot)se
(version 5). Thanks!

cheers ./daniel

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-03-18 23:06:18 Re: ECPG installcheck tests fail if PGDATABASE is set
Previous Message Daniel Gustafsson 2018-03-18 22:59:43 Re: Online enabling of checksums