Re: Online enabling of checksums

From: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Michael Banck <michael(dot)banck(at)credativ(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Online enabling of checksums
Date: 2018-03-19 10:40:56
Message-ID: 9D280DAB-EFE6-406B-B3F3-453B51968BA1@yandex-team.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Daniel!

> 19 марта 2018 г., в 4:01, Daniel Gustafsson <daniel(at)yesql(dot)se> написал(а):
>
> Fixed in patch just posted in 84693D0C-772F-45C2-88A1-85B4983A5780(at)yesql(dot)se
> (version 5). Thanks!

I've been hacking a bit in neighboring thread.
And come across one interesting thing. There was a patch on this CF on enabling checksums for SLRU. The thing is CLOG is not protected with checksums right now. But the bad thing about it is that there's no reserved place for checksums in SLRU.
And this conversion from page without checksum to page with checksum is quite impossible online.

If we commit online checksums before SLRU checksums, we will need very neat hacks if we decide to protect SLRU eventually.

What do you think about this problem?

Best regards, Andrey Borodin.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2018-03-19 10:57:48 Re: User defined data types in Logical Replication
Previous Message David Rowley 2018-03-19 10:35:43 Re: [HACKERS] path toward faster partition pruning