| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Remove obsolate comments from 047_checkpoint_physical_slot |
| Date: | 2025-09-25 07:32:40 |
| Message-ID: | 1B51369C-EF99-4D97-A201-66F000640B94@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 25 Sep 2025, at 09:23, Hayato Kuroda (Fujitsu) <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear hackers,
>
>> While reviewing others, I found $SUBJECT.
>
> I found another cleanup point related with this. In CreateCheckPoint():
>
> ```
> #ifdef USE_INJECTION_POINTS
> INJECTION_POINT("checkpoint-before-old-wal-removal");
> #endif
> ```
>
> Here USE_INJECTION_POINTS check is not needed. If the feature is disabled,
> the macro function would be ((void) name). IIUC, we are using the macro if if-branch
> exists.
+1, that's not needed (and not used elsewhere in the code either).
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-09-25 07:45:26 | Re: Add support for specifying tables in pg_createsubscriber. |
| Previous Message | Hayato Kuroda (Fujitsu) | 2025-09-25 07:23:33 | RE: Remove obsolate comments from 047_checkpoint_physical_slot |