| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | Re: Remove obsolate comments from 047_checkpoint_physical_slot |
| Date: | 2025-09-25 07:59:41 |
| Message-ID: | aNT2bbtG8vyEo5_K@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 25, 2025 at 09:32:40AM +0200, Daniel Gustafsson wrote:
> On 25 Sep 2025, at 09:23, Hayato Kuroda (Fujitsu) <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>> Here USE_INJECTION_POINTS check is not needed. If the feature is disabled,
>> the macro function would be ((void) name). IIUC, we are using the macro if if-branch
>> exists.
>
> +1, that's not needed (and not used elsewhere in the code either).
Yeah, let's remove that. Simplification in the backend code is the
whole point of the double definition of the INJECTION_POINT() macro in
injection_point.h.
And the comments of the test 047 are indeed not required anymore.
Good catch.
If you want to go ahead and clean up all that, Daniel, please feel
free. If not, I'm OK to pull the trigger on this one.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-09-25 08:01:00 | Re: Fix incorrect function comment of stringToNodeInternal |
| Previous Message | Richard Guo | 2025-09-25 07:55:57 | Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master |