| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
| Subject: | RE: Remove obsolate comments from 047_checkpoint_physical_slot |
| Date: | 2025-09-25 07:23:33 |
| Message-ID: | OSCPR01MB14966C8015DEB05ABEF2CE077F51FA@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear hackers,
> While reviewing others, I found $SUBJECT.
I found another cleanup point related with this. In CreateCheckPoint():
```
#ifdef USE_INJECTION_POINTS
INJECTION_POINT("checkpoint-before-old-wal-removal");
#endif
```
Here USE_INJECTION_POINTS check is not needed. If the feature is disabled,
the macro function would be ((void) name). IIUC, we are using the macro if if-branch
exists.
E.g., another injection point "create-restart-point" does not have the #ifdef part.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-09-25 07:32:40 | Re: Remove obsolate comments from 047_checkpoint_physical_slot |
| Previous Message | Yugo Nagata | 2025-09-25 07:22:16 | Re: Suggestion to add --continue-client-on-abort option to pgbench |