Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Date: 2018-04-10 13:46:32
Message-ID: 17165.1523367992@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
> Compilation of external extensions using PGXS appears to be broken
> since this commit:

Ouch, sorry.

> I think the best fix if to define NO_GENERATED_HEADERS in pgxs.mk,
> patch attached.

Hm. I wonder if we don't also want NO_TEMP_INSTALL, like the doc/src/sgml
makefile. I don't know whether "make check" could be useful in a PGXS
build, but certainly that recipe for making a temp install isn't gonna
work.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2018-04-10 13:58:35 pgsql: Fix comment on B-tree insertion fastpath condition.
Previous Message Teodor Sigaev 2018-04-10 12:00:28 Re: pgsql: Fix behavior of ~> (cube, int) operator

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2018-04-10 13:47:53 Re: [HACKERS] GSoC 2017: Foreign Key Arrays
Previous Message Heikki Linnakangas 2018-04-10 13:37:55 Re: Bugs in TOAST handling, OID assignment and redo recovery