Re: pgsql: Fix behavior of ~> (cube, int) operator

Pushed, thank you

Alexander Korotkov wrote:
> On Sun, Jan 21, 2018 at 11:20 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us
> <mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us>> wrote:
>
> Teodor Sigaev <teodor(at)sigaev(dot)ru <mailto:teodor(at)sigaev(dot)ru>> writes:
> > Fix behavior of ~> (cube, int) operator
>
> This patch has caused Coverity to complain, correctly AFAICS, about
> dead code in cube_coord_llur in the back branches:
>
> 1628            /* Inverse value if needed */
> 1629            if (inverse)
> >>>     CID 1463943:  Control flow issues  (DEADCODE)
> >>>     Execution cannot reach this statement: "result = -result;".
> 1630                    result = -result;
> 1631
> 1632            PG_RETURN_FLOAT8(result);
>
> Seems to be due to sloppy division of changes between f50c80dbb (which
> was not back-patched) and 563a053bd.  Please fix.
>
>
> Thank you for catching this.  You diagnosis is right.
> I propose to commit the attached patch to 10 and 9.6.
>
> ------
> Alexander Korotkov
> Postgres Professional:http://www.postgrespro.com <http://www.postgrespro.com/>
> The Russian Postgres Company

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/