| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers. |
| Date: | 2018-04-10 16:13:01 |
| Message-ID: | CAOBaU_bMq6UNwB6HYo_LWL2kZV=T_VsY9wJW8Wum6Smnppu5MA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, Apr 10, 2018 at 3:46 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Julien Rouhaud <rjuju123(at)gmail(dot)com> writes:
>> I think the best fix if to define NO_GENERATED_HEADERS in pgxs.mk,
>> patch attached.
>
> Hm. I wonder if we don't also want NO_TEMP_INSTALL, like the doc/src/sgml
> makefile. I don't know whether "make check" could be useful in a PGXS
> build, but certainly that recipe for making a temp install isn't gonna
> work.
If I understand correctly, PGXS.mk already forbids a "make check" if
PGXS is defined. And it seems that postgres' contribs rely on
including PGXS.mk, setting NO_PGXS and doing a "make check", so
NO_TEMP_INSTALL shouldn't be needed.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-04-10 16:29:12 | Re: pgsql: Support partition pruning at execution time |
| Previous Message | Robert Haas | 2018-04-10 15:59:40 | Re: pgsql: Support partition pruning at execution time |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-04-10 16:18:46 | Re: Online enabling of checksums |
| Previous Message | Teodor Sigaev | 2018-04-10 16:03:11 | Re: WIP: Covering + unique indexes. |