Re: Add minimal C example and SQL registration example for custom table access methods.

From: Roberto Mello <roberto(dot)mello(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add minimal C example and SQL registration example for custom table access methods.
Date: 2023-11-15 23:28:24
Message-ID: 170009090469.2631681.9401767800677948331.pgcf@coridan.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers

Suggestion:

In the C example you added you mention in the comment:

+ /* Methods from TableAmRoutine omitted from example, but all
+ non-optional ones must be provided here. */

Perhaps you could provide a "see <xyz>" to point the reader finding your example where he could find these non-optional methods he must provide?

Nitpicking a little: your patch appears to change more lines than it does, because it added line breaks earlier in the lines. I would generally avoid that unless there's good reason to do so.

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message Daniel Rinehart 2023-11-16 14:35:15 Re: Additional Notes
Previous Message Laurenz Albe 2023-11-15 18:05:05 Re: Additional Notes

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2023-11-16 00:00:00 Re: [HACKERS] Allow INSTEAD OF DELETE triggers to modify the tuple for RETURNING
Previous Message Andres Freund 2023-11-15 23:17:18 Re: lazy_scan_heap() should release lock on buffer before vacuuming FSM