| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remove partColsUpdated |
| Date: | 2025-10-16 00:18:41 |
| Message-ID: | 1339305.1760573921@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> writes:
> On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> This was first added in commit 2f17844 (v11), and AFAICT it was only used
>> for a variable named update_tuple_routing_needed in ExecInitModifyTable(),
>> which was removed by commit c5b7ba4 (v14). Any objections to removing it
>> now?
> Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it.
I just had a look through https://codesearch.debian.net/ and couldn't
find any evidence that any extensions are using it, so +1 to remove.
> Maybe back patch through 14?
Certainly not. That would cause an ABI break for any extension that
touches later fields in PlannerInfo or ModifyTable. We don't expect
extensions to get recompiled for minor releases.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-10-16 01:18:39 | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Previous Message | Peter Smith | 2025-10-16 00:13:38 | Re: POC: enable logical decoding when wal_level = 'replica' without a server restart |