| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remove partColsUpdated |
| Date: | 2025-10-15 23:52:09 |
| Message-ID: | 6A9F3EEE-290C-4E51-8F41-12C302C6FB26@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> This was first added in commit 2f17844 (v11), and AFAICT it was only used
> for a variable named update_tuple_routing_needed in ExecInitModifyTable(),
> which was removed by commit c5b7ba4 (v14). Any objections to removing it
> now?
>
> --
> nathan
> <v1-0001-remove-partColsUpdated.patch>
Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it. Maybe back patch through 14?
I tried to build, and “make check” with this patch, and everything looks good.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-10-16 00:05:58 | Should we say "wal_level = logical" instead of "wal_level >= logical" |
| Previous Message | Tom Lane | 2025-10-15 23:39:03 | Re: Instability of phycodorus in pg_upgrade tests with JIT |