Re: remove partColsUpdated

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: remove partColsUpdated
Date: 2025-10-16 06:03:10
Message-ID: aPCKnuDoLsU3br17@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 15, 2025 at 08:18:41PM -0400, Tom Lane wrote:
> Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> writes:
>> On Oct 15, 2025, at 23:50, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>>> This was first added in commit 2f17844 (v11), and AFAICT it was only used
>>> for a variable named update_tuple_routing_needed in ExecInitModifyTable(),
>>> which was removed by commit c5b7ba4 (v14). Any objections to removing it
>>> now?
>
>> Looks like this is only one assignment to it and nobody reads it. I don’t see a reason to retain it.
>
> I just had a look through https://codesearch.debian.net/ and couldn't
> find any evidence that any extensions are using it, so +1 to remove.

Yes, that feels OK. I've also spent some time looking at what github
is able to refer to, but I can only find traces of forked code or
cloned repositories in the open, without specific uses for it. +1.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Renzo Dani 2025-10-16 06:07:42 Re: Extend documentation for pg_stat_replication.backend_xmin
Previous Message Tom Lane 2025-10-16 05:38:19 Re: Preserve index stats during ALTER TABLE ... TYPE ...