Re: [BUG] temporary file usage report with extended protocol and unnamed portals

On Wed, Oct 15, 2025 at 05:58:37PM +0900, Michael Paquier wrote:
> I did not really get the use of wait_for_log(). The query sequences
> are well-timed, hence a set of log_contains() should be enough with
> a correct offset to point to a position in the logs.

Just a point of detail here. v13 and v12 of the patch relied on
wait_for_log(), which returns the size of the log file, updating the
offset used in the follow-up tests. But failures would cause the test
to be stuck until a timeout kicks in to stop the test. That part was
annoying.

> It's a bit late here, and I am not completely done yet. Here is for
> now what I have for the tests. I still need to check more its
> stability with more runs, and also I need to do a second pass. The CI
> looks stable here at least.

Another thing I have added is a check for STATEMENT in the two tests
where we do not expected a statement to be logged. I have also done a
couple more runs in the CI and locally, without noticing any failures,
so applied the result. Now let's see if the buildfarm says something.
The first results are stable, I'll keep an eye on the whole.
--
Michael