|From:||Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>|
|To:||Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>|
|Cc:||Pg Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: list partition constraint shape|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2018/01/26 21:31, Etsuro Fujita wrote:
> (2018/01/26 10:15), Amit Langote wrote:
>> On 2018/01/25 21:17, Etsuro Fujita wrote:
>>> Some minor comments:
>>> + /*
>>> + * Construct an ArrayExpr for the non-null partition
>>> + * values
>>> + */
>>> + arrexpr = makeNode(ArrayExpr);
>>> + arrexpr->array_typeid =
>>> + !type_is_array(key->parttypid)
>>> + ?
>>> + : key->parttypid;
>>> We test the type_is_array() above in this bit, so I don't think we need to
>>> test that again here.
>> Ah, you're right. Fixed.
> Thanks. I think the updated version is fine, but I think we can simplify
> the change in this part a bit further, so I modified your patch. I also
> adjusted some comments in that change a little bit. Attached is a modified
> version of the patch. What do you think about that? Please let me know.
> If that is okay, I'll mark this as Ready for Committer.
That looks good, thanks.
|Next Message||Amit Langote||2018-01-29 01:08:51||Re: [Sender Address Forgery]Re: pg_(total_)relation_size and partitioned tables|
|Previous Message||Bruce Momjian||2018-01-29 00:16:29||Re: Built-in connection pooling|