| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: list partition constraint shape |
| Date: | 2018-01-29 06:15:14 |
| Message-ID: | 5A6EBBF2.5040304@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2018/01/29 9:50), Amit Langote wrote:
> On 2018/01/26 21:31, Etsuro Fujita wrote:
>> Attached is a modified
>> version of the patch. What do you think about that? Please let me know.
>> If that is okay, I'll mark this as Ready for Committer.
>
> That looks good, thanks.
Cool! One thing I noticed to revise the patch a bit further is to add
an assertion to make_partition_op_expr that the number of the right-hand
inputs to generate an operator expression from for list-partitioning
should be >=1; in that case we call that function if there is at least
one non-null partition value as the right-hand input, so that should be
asserted successfully there. I think the assertion is a good thing, so
I modified the patch. Updated patch attached. Because I made no
changes other than that, I'll make this as Ready for Committer.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Change-how-list-partition-constraint-is-emitted-efujita-2.patch | text/x-diff | 12.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2018-01-29 06:19:29 | Re: Reorder C includes in partition.c |
| Previous Message | Tom Lane | 2018-01-29 05:57:59 | Re: Boolean partitions syntax |