Re: list partition constraint shape

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: list partition constraint shape
Date: 2018-01-26 12:31:58
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

(2018/01/26 10:15), Amit Langote wrote:
> On 2018/01/25 21:17, Etsuro Fujita wrote:
>> Some minor comments:
>> + /*
>> + * Construct an ArrayExpr for the non-null partition
>> + * values
>> + */
>> + arrexpr = makeNode(ArrayExpr);
>> + arrexpr->array_typeid =
>> + !type_is_array(key->parttypid[0])
>> + ? get_array_type(key->parttypid[0])
>> + : key->parttypid[0];
>> We test the type_is_array() above in this bit, so I don't think we need to
>> test that again here.
> Ah, you're right. Fixed.

Thanks. I think the updated version is fine, but I think we can
simplify the change in this part a bit further, so I modified your
patch. I also adjusted some comments in that change a little bit.
Attached is a modified version of the patch. What do you think about
that? Please let me know. If that is okay, I'll mark this as Ready for

> Attached updated patch. Thanks again.

Thanks for updating the patch!

Best regards,
Etsuro Fujita

Attachment Content-Type Size
v3-0001-Change-how-list-partition-constraint-is-emitted-efujita.patch text/x-diff 12.5 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-01-26 12:45:52 Re: [Sender Address Forgery]Re: pg_(total_)relation_size and partitioned tables
Previous Message Yugo Nagata 2018-01-26 12:30:49 Re: [HACKERS] [PATCH] Lockable views