Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding

From: cca5507 <cca5507(at)qq(dot)com>
To: ocean_li_996 <ocean_li_996(at)163(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding
Date: 2025-11-23 05:31:49
Message-ID: tencent_95D13240784107B9768CA1DD851DB5B52908@qq.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Haiyang,

> The patch in attachment is better for me. What do you think?

The v2-0001 LGTM.

A small suggestion:

We should move the 'break' out of the 'if', because we don't want it fall through to XLOG_HEAP2_REWRITE if we are fast-forwarding.

--
Regards,
ChangAo Chen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chengpeng Yan 2025-11-23 05:33:44 Re: tuple radix sort
Previous Message Michael Paquier 2025-11-23 04:38:53 Re: Remove unused fields from BufferCacheNumaRec