Re:Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding

From: ocean_li_996 <ocean_li_996(at)163(dot)com>
To: cca5507 <cca5507(at)qq(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re:Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding
Date: 2025-11-23 06:33:14
Message-ID: 5669a88e.eee.19aaf6aa83a.Coremail.ocean_li_996@163.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi ChangAo,
At 2025-11-23 13:31:49, "cca5507" <cca5507(at)qq(dot)com> wrote:
>> The patch in attachment is better for me. What do you think?
>
>The v2-0001 LGTM.
>
>A small suggestion:
>
>We should move the 'break' out of the 'if', because we don't want it fall through to XLOG_HEAP2_REWRITE if we are fast-forwarding.

Fair. The patch updated is provided in attachment.

Best regards,
Haiyang Li

Attachment Content-Type Size
v3-0001-Handle-XLOG_HEAP2_NEW_CID-in-fast-forward.patch application/octet-stream 1.6 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message sunil s 2025-11-23 06:42:23 Re: Unnecessary delay in streaming replication due to replay lag
Previous Message Nico Williams 2025-11-23 06:16:56 Re: RFC 9266: Channel Bindings for TLS 1.3 support