Re: Remove unused fields from BufferCacheNumaRec

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Cc: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Remove unused fields from BufferCacheNumaRec
Date: 2025-11-23 04:38:53
Message-ID: aSKP3W2FClbFbE8o@paquier.xyz
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Nov 23, 2025 at 12:27:08PM +0800, Chao Li wrote:
> 1. "This loop stores into os_page_ptrs[]” is understandable, but
> feels a bit incomplete to me as non-English-speaking. I understand
> your intention is to make “stores” and “touches” to share
> “addresses”. But this is not a strong opinion comment, if Michael
> considers okay, I will be fine as well.

I have actually used something slightly different at the end, and
appl-ed the result.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message cca5507 2025-11-23 05:31:49 Re: [BUG] Incorrect historic snapshot may be serialized to disk during fast-forwarding
Previous Message Sugamoto Shinya 2025-11-23 04:32:38 [PATCH] Add error hints for invalid COPY options