Re: Undocumented feature costs a lot of performance in COPY IN

From: Doug McNaught <doug(at)wireboard(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Undocumented feature costs a lot of performance in COPY IN
Date: 2001-12-04 20:19:27
Message-ID: m3elmad9gw.fsf@belphigor.mcnaught.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> and indeed, only the first character is used by COPY OUT. But COPY IN
> is presently coded so that if multiple characters are mentioned in
> USING DELIMITERS, any one of them will be taken as a field delimiter.
>
> I would like to change the code to just "if (c == delim[0])",
> which should buy back most of that 20% and make the behavior match the
> documentation. Question for the list: is this a bad change? Is anyone
> out there actually using this undocumented behavior?

Not I.

As an utter nitpick, the syntax should IMHO be USING DELIMITER (no S)
if there is only one possible delimiter character. But that *would*
break lots of apps so I don't advocate it. ;)

-Doug
--
Let us cross over the river, and rest under the shade of the trees.
--T. J. Jackson, 1863

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-12-04 20:20:52 Re: Undocumented feature costs a lot of performance in COPY
Previous Message Tom Lane 2001-12-04 20:14:58 Re: Undocumented feature costs a lot of performance in COPY IN

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-12-04 20:20:52 Re: Undocumented feature costs a lot of performance in COPY
Previous Message Tom Lane 2001-12-04 20:14:58 Re: Undocumented feature costs a lot of performance in COPY IN