From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Doug McNaught <doug(at)wireboard(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Undocumented feature costs a lot of performance in COPY |
Date: | 2001-12-04 21:18:34 |
Message-ID: | 200112042118.fB4LIYL07607@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
>
> > and indeed, only the first character is used by COPY OUT. But COPY IN
> > is presently coded so that if multiple characters are mentioned in
> > USING DELIMITERS, any one of them will be taken as a field delimiter.
> >
> > I would like to change the code to just "if (c == delim[0])",
> > which should buy back most of that 20% and make the behavior match the
> > documentation. Question for the list: is this a bad change? Is anyone
> > out there actually using this undocumented behavior?
>
> Not I.
>
> As an utter nitpick, the syntax should IMHO be USING DELIMITER (no S)
> if there is only one possible delimiter character. But that *would*
> break lots of apps so I don't advocate it. ;)
We could support keywords DELIMITER and DELIMITERS and only document the first
one.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2001-12-04 21:21:16 | Re: FW: [CYGWIN] 7.2b3 postmaster doesn't start on Win98 |
Previous Message | Bill Studenmund | 2001-12-04 20:31:47 | Re: Undocumented feature costs a lot of performance in |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2001-12-04 21:21:31 | Re: date formatting and tab-complete patch |
Previous Message | Bill Studenmund | 2001-12-04 20:31:47 | Re: Undocumented feature costs a lot of performance in |