Re: Undocumented feature costs a lot of performance in COPY IN

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Undocumented feature costs a lot of performance in COPY IN
Date: 2001-12-04 20:14:58
Message-ID: 2993.1007496898@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Yes, please fix it. In fact, I think we should throw an error if more
> than one character is specified as a delimiter. Saying we ignore
> multiple characters in the documentation is not enough when we silently
> ignore them in the code.

Well, it'd be an easy enough addition:

if (strlen(delim) != 1)
elog(ERROR, "COPY delimiter must be a single character");

This isn't multibyte-aware, but then neither is the implementation;
delimiters that are multibyte characters won't work at the moment.

Any comments out there?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Doug McNaught 2001-12-04 20:19:27 Re: Undocumented feature costs a lot of performance in COPY IN
Previous Message Bill Studenmund 2001-12-04 20:12:19 Re: Undocumented feature costs a lot of performance in

Browse pgsql-patches by date

  From Date Subject
Next Message Doug McNaught 2001-12-04 20:19:27 Re: Undocumented feature costs a lot of performance in COPY IN
Previous Message Bill Studenmund 2001-12-04 20:12:19 Re: Undocumented feature costs a lot of performance in