Re: Extensions vs PGXS' MODULE_PATHNAME handling

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Extensions vs PGXS' MODULE_PATHNAME handling
Date: 2011-02-16 20:09:17
Message-ID: m262sjd9n6.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> [ scratches head ... ] Why is your version generating so many
> unnecessary @extschema@ uses?

I just ran create table tomlist as select your query and create table
dimlist as select my query, then:

dim=# select * from tomlist except select * from dimlist;
desc
--------------------------------------------------------------------------------------------------
ALTER EXTENSION hstore ADD operator family @extschema(at)(dot)gin_hstore_ops for access method gin;
ALTER EXTENSION hstore ADD operator class @extschema(at)(dot)btree_hstore_ops for access method btree;
ALTER EXTENSION hstore ADD operator family @extschema(at)(dot)hash_hstore_ops for access method hash;
ALTER EXTENSION hstore ADD operator class @extschema(at)(dot)gist_hstore_ops for access method gist;
ALTER EXTENSION hstore ADD operator family @extschema(at)(dot)gist_hstore_ops for access method gist;
ALTER EXTENSION hstore ADD cast from text[] to @extschema(at)(dot)hstore;
ALTER EXTENSION hstore ADD operator class @extschema(at)(dot)gin_hstore_ops for access method gin;
ALTER EXTENSION hstore ADD operator family @extschema(at)(dot)btree_hstore_ops for access method btree;
ALTER EXTENSION hstore ADD operator class @extschema(at)(dot)hash_hstore_ops for access method hash;
(9 rows)

No difference on @extschema@ use here.

dim=# select t.desc, d.desc from tomlist t natural join dimlist d limit 1;
-[ RECORD 1 ]---------------------------------------------
desc | ALTER EXTENSION hstore ADD type @extschema(at)(dot)hstore;
desc | ALTER EXTENSION hstore ADD type @extschema(at)(dot)hstore;

dim=# select t.desc, d.desc from tomlist t natural join dimlist d limit 1 offset 10;
-[ RECORD 1 ]---------------------------------------------------------------------------
desc | ALTER EXTENSION hstore ADD function @extschema(at)(dot)slice(@extschema(at)(dot)hstore,text[]);
desc | ALTER EXTENSION hstore ADD function @extschema(at)(dot)slice(@extschema(at)(dot)hstore,text[]);

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-02-16 20:18:14 Re: [COMMITTERS] pgsql: Cleanup ClusterInfo initialization in pg_upgrade
Previous Message Thom Brown 2011-02-16 19:35:57 Re: Spontaneous PITR standby activiation