From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Cleanup ClusterInfo initialization in pg_upgrade |
Date: | 2011-02-16 20:18:14 |
Message-ID: | 201102162018.p1GKIEZ01737@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera wrote:
> Cleanup ClusterInfo initialization in pg_upgrade
Global structs are already initialized to zero, so no need to initialize
them. I discussed this with Alvaro, and he suggested that there is no
need to free memory before we exit. The attached, applied patch makes
both changes.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
Attachment | Content-Type | Size |
---|---|---|
/rtmp/diff | text/x-diff | 2.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2011-02-16 21:16:54 | pgsql: Better support for thread-support flag detection with clang |
Previous Message | Bruce Momjian | 2011-02-16 20:17:30 | pgsql: In pg_upgrade, no need to initialize global struct values; they |
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2011-02-16 20:23:40 | Re: Fix corner case for binary upgrade: extension functions in pg_catalog. |
Previous Message | Dimitri Fontaine | 2011-02-16 20:09:17 | Re: Extensions vs PGXS' MODULE_PATHNAME handling |