Re: some more include removal from headers

Hi,

On 2026-04-02 20:24:29 +0200, Álvaro Herrera wrote:
> On 2026-Apr-02, Andres Freund wrote:
> > After the attached patches, a change to bufmgr.h triggers rebuilding 213
> > files, before it was 323. Not perfect, but better.
> >
> > Would be nice to get rid of the bufmgr.h includes in access/nbtree.h and such,
> > but it looks like that'd be a bit more work.
> >
> > I included your catalog/publication.h in it, as my version had surprisingly
> > extensive bitrot...
>
> I ran each patch individually under headerscheck and a full tree
> compile; they all pass for me. Also, each change is sensible on its own.
>
> Looking at what else includes bufmgr.h, I think the minimum it can
> reduced to is compiling 157 files when you change bufmgr.h, per the
> patches attached here. Most of them are direct inclusions, so reducing
> further is tough. The only one we could blame is xlogutils.h, but it
> needs the ReadBufferMode enum, so in order to do better, we'd have to
> split bufmgr.h in two.

I think you may have forgotten to attach the changes?

Greetings,

Andres Freund