Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

From: Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "David E(dot) Wheeler" <david(at)justatheory(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Date: 2026-04-02 19:57:28
Message-ID: CA+v5N40v=o=ybDcnmYANY535zBa_5CV-yCoFaOShgjU-dq9=zg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 2, 2026 at 10:21 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

>
> On 2026-03-28 Sa 11:58 AM, David E. Wheeler wrote:
>
> On Mar 28, 2026, at 11:02, Andrew Dunstan <andrew(at)dunslane(dot)net> <andrew(at)dunslane(dot)net> wrote:
>
>
> The key_name production is what allows a keyword to also be used as an object key in $.keyname syntax. The trim keywords (ltrim, rtrim, btrim) were added there, so $.ltrim as a key works. But $.lower,
> $.upper, $.initcap, $.replace, and $.split_part as keys would all break.
>
> Ooh, right. It has been so long since I looked at this stuff that I forgot. Thanks for the reminder.
>
>
> There are tests added for it.
>
> And for this!
>
>
>
>
> Committed.
>
Boom! Thanks so much for this.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-04-02 20:44:41 Re: some more include removal from headers
Previous Message Robert Haas 2026-04-02 19:56:26 Re: pgsql: Reduce log level of some logical decoding messages from LOG to D