| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: some more include removal from headers |
| Date: | 2026-04-02 22:14:51 |
| Message-ID: | 202604022213.ijh54ljfsfb7@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
On 2026-Apr-02, Andres Freund wrote:
> On 2026-04-02 20:24:29 +0200, Álvaro Herrera wrote:
> > Looking at what else includes bufmgr.h, I think the minimum it can
> > reduced to is compiling 157 files when you change bufmgr.h, per the
> > patches attached here. Most of them are direct inclusions, so reducing
> > further is tough. The only one we could blame is xlogutils.h, but it
> > needs the ReadBufferMode enum, so in order to do better, we'd have to
> > split bufmgr.h in two.
>
> I think you may have forgotten to attach the changes?
Hm, so I did. Here they are.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Las mujeres son como hondas: mientras más resistencia tienen,
más lejos puedes llegar con ellas" (Jonas Nightingale, Leap of Faith)
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-don-t-include-bufmgr.h-in-nbtree.h.patch | text/x-diff | 5.1 KB |
| 0002-don-t-include-bufmgr.h-in-hash.h.patch | text/x-diff | 3.5 KB |
| 0003-don-t-include-bufmgr.h-in-gist_private.h.patch | text/x-diff | 2.3 KB |
| 0004-don-t-include-bufmgr.h-in-gin_private.h.patch | text/x-diff | 4.8 KB |
| 0005-don-t-include-bufmgr.h-in-bufmask.h.patch | text/x-diff | 709 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Haibo Yan | 2026-04-02 22:19:47 | Re: refactor ExecInitPartitionInfo |
| Previous Message | Masahiko Sawada | 2026-04-02 22:13:18 | Re: Initial COPY of Logical Replication is too slow |