Re: Latest Data::Dumper breaks hstore_plperl regression test

On 05/13/2017 11:32 PM, Robert Haas wrote:
> On Sat, May 13, 2017 at 6:22 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Or at least, that's what I surmise from the fact that buildfarm critter
>> caiman has been failing that test for the last day or so, with symptoms
>> indicating whitespace changes in Data::Dumper output. Some poking into
>> the Fedora repo shows that rawhide updated perl-Data-Dumper from 2.161
>> to 2.167 on May 11, so that fits ...
> Depending on the precise details of how Data::Dumper prints things
> doesn't seem like a particularly good idea.
>

I'd be inclined to set $Data::Dumper::Indent to 0 which would suppress
all indentation, and adjusting the test results accordingly. We already
set $Data::Dumper::Sortkeys to 1, so there's precedent for controlling
how it presents data back to us.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services